-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packetserver: Rename Counterparty to Channel #7429
packetserver: Rename Counterparty to Channel #7429
Conversation
Ref: #7333 Needs to be done in channel/v2 also, I can handle that if nobody has picked it up yet? cc. @DimitrisJim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to get this merged and keep marching foward! Thanks @AdityaSripal!
Will create follow up issues in the morning from my comments here and organise them.
Tests all passing, lgtm!
func (k *Keeper) GetV2Counterparty(ctx context.Context, portID, channelID string) (packetserver.Counterparty, bool) { | ||
// GetV2Channel returns a version 2 channel for the given port and channel ID | ||
// by converting the v1 channel into a version 2 channel | ||
func (k *Keeper) GetV2Channel(ctx context.Context, portID, channelID string) (packetserver.Channel, bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can probably remove this from classic at some point later and have it fully in the v2 pkg/codepath.
// getCmdQueryClient defines the command to query the client information (creator and counterparty) for the given client ID. | ||
func getCmdQueryClient() *cobra.Command { | ||
// getCmdQueryChannel defines the command to query the client information (creator and channel) for the given client ID. | ||
func getCmdQueryChannel() *cobra.Command { | ||
cmd := &cobra.Command{ | ||
Use: "client [client-id]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will need to update these also within v2. I don't think there's any point in refactoring them in packet-server as it will eventually be removed, right?
happy to create an issue for CLI's and queries in v2 pkg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be able to move the whole folder at some point and do some tweaks. Think these can be moved along with the move of the types in channel/v2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a couple comments that need updating but fine to comb through those too later. Looks great to me!
Quality Gate passed for 'ibc-go'Issues Measures |
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.